----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/#review143875 -----------------------------------------------------------
3rdparty/libprocess/include/process/reap.hpp (line 22) <https://reviews.apache.org/r/40413/#comment209828> I tend to prefer leaving includes when we explicitly make use of the type, as is the case with `Option` here. What do you think? - Greg Mann On July 14, 2016, 12:21 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40413/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 12:21 a.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3934 > https://issues.apache.org/jira/browse/MESOS-3934 > > > Repository: mesos > > > Description > ------- > > The reaper singleton must be unified with `process::initialize` so > that it also falls under the scope of reinitialization. The singleton > must also not be guarded by `Once`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/reap.hpp > 1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 > 3rdparty/libprocess/src/process.cpp > 9661386afd4fddd1877d55941fa403afc9230280 > 3rdparty/libprocess/src/reap.cpp ac60c6d769076912293950432266c956d6c7e705 > > Diff: https://reviews.apache.org/r/40413/diff/ > > > Testing > ------- > > Tests done in a subsequent review. > > > Thanks, > > Joseph Wu > >
