> On July 28, 2016, 1:01 p.m., Greg Mann wrote: > > 3rdparty/libprocess/include/process/reap.hpp, line 22 > > <https://reviews.apache.org/r/40413/diff/3/?file=1443631#file1443631line22> > > > > I tend to prefer leaving includes when we explicitly make use of the > > type, as is the case with `Option` here. What do you think?
Agreed. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/#review143875 ----------------------------------------------------------- On July 29, 2016, 4:58 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40413/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 4:58 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, > and Vinod Kone. > > > Bugs: MESOS-3934 > https://issues.apache.org/jira/browse/MESOS-3934 > > > Repository: mesos > > > Description > ------- > > The reaper singleton must be unified with `process::initialize` so > that it also falls under the scope of reinitialization. The singleton > must also not be guarded by `Once`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/reap.hpp > 1a9709c618c5ddc9d2b7492cc1855a11f1fc4fb9 > 3rdparty/libprocess/src/process.cpp > 7f331b812de2f0437838f48e0959441c8e04c358 > 3rdparty/libprocess/src/reap.cpp ac60c6d769076912293950432266c956d6c7e705 > > Diff: https://reviews.apache.org/r/40413/diff/ > > > Testing > ------- > > Tests done in a subsequent review. > > > Thanks, > > Joseph Wu > >
