----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50179/#review144012 -----------------------------------------------------------
Fix it, then Ship it! A few minor nits. I can fix before committing. src/slave/CMakeLists.txt (lines 24 - 25) <https://reviews.apache.org/r/50179/#comment209954> You probably want to keep these subdirectories. src/slave/cmake/SlaveConfigure.cmake (line 32) <https://reviews.apache.org/r/50179/#comment209956> For consistency, this target should be called the `MESOS_LOGROTATE_LOGGER_TARGET`. src/slave/cmake/SlaveConfigure.cmake (line 33) <https://reviews.apache.org/r/50179/#comment209957> This is actually an executable that the LogrotateContainerLogger relies on, inside and outside of tests. - Joseph Wu On July 22, 2016, 12:29 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50179/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 12:29 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added mesos-logrotate-logger utility executable. > > > Diffs > ----- > > src/slave/CMakeLists.txt bb9ad62b2372ca038c43a20d9906aaf43d9ead41 > src/slave/cmake/SlaveConfigure.cmake > ced57496970f1d7edf9e7e443b22d14d2ee948f0 > > Diff: https://reviews.apache.org/r/50179/diff/ > > > Testing > ------- > > cmake .. && make mesos-logrotate-logger > GLOG_v=1 ./src/mesos-tests > --gtest_filter="ContainerLogger*.LOGROTATE_RotateInSandbox" should run > successfully. > > > Thanks, > > Srinivas Brahmaroutu > >
