> On July 28, 2016, 3:12 p.m., Joseph Wu wrote: > > A few minor nits. I can fix before committing.
Oh, and I will disable this target on Windows for now. The implementation currently includes some non-Windows headers. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50179/#review144012 ----------------------------------------------------------- On July 22, 2016, 12:29 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50179/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 12:29 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added mesos-logrotate-logger utility executable. > > > Diffs > ----- > > src/slave/CMakeLists.txt bb9ad62b2372ca038c43a20d9906aaf43d9ead41 > src/slave/cmake/SlaveConfigure.cmake > ced57496970f1d7edf9e7e443b22d14d2ee948f0 > > Diff: https://reviews.apache.org/r/50179/diff/ > > > Testing > ------- > > cmake .. && make mesos-logrotate-logger > GLOG_v=1 ./src/mesos-tests > --gtest_filter="ContainerLogger*.LOGROTATE_RotateInSandbox" should run > successfully. > > > Thanks, > > Srinivas Brahmaroutu > >
