-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated July 28, 2016, 10:46 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebase with master.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp
bb6947fcecb5b78047e98d10fc1278c612a69548
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact on runtime performance in
allocations. Also, there is no visible impact in performance when shared
resources are added in the tests.
With the patch (and no shared resources)
----------------------------------------
round 0 allocate took 3.19704secs to make 200 offers
round 50 allocate took 3.240605secs to make 200 offers
round 100 allocate took 3.227024secs to make 200 offers
round 150 allocate took 3.225281secs to make 200 offers
round 199 allocate took 3.26036secs to make 200 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
round 0 allocate took 3.279115secs to make 200 offers
round 50 allocate took 3.273396secs to make 200 offers
round 100 allocate took 3.278509secs to make 200 offers
round 150 allocate took 3.275959secs to make 200 offers
round 199 allocate took 3.278151secs to make 200 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
round 0 allocate took 3.251739secs to make 200 offers
round 50 allocate took 3.263777secs to make 200 offers
round 100 allocate took 3.263079secs to make 200 offers
round 150 allocate took 3.263114secs to make 200 offers
round 199 allocate took 3.236228secs to make 200 offers
Based on HEAD, with all regular resources (no shared resources in HEAD
supported)
---------------------------------------------------------------------------------
round 0 allocate took 2.925681secs to make 200 offers
round 50 allocate took 2.922036secs to make 200 offers
round 100 allocate took 2.909337secs to make 200 offers
round 150 allocate took 2.914093secs to make 200 offers
round 199 allocate took 2.923762secs to make 200 offers
Thanks,
Anindya Sinha
