> On July 27, 2016, 11:32 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 60 > > <https://reviews.apache.org/r/50482/diff/4/?file=1455009#file1455009line60> > > > > why is this scope.state instead of scope.data?
In the previous code, we didn't use JSONP, so the type of `data` and `$scope.data` here are string. `data` need to `JSON.parse` first then assign to `$scope.state` as a JSON object. After we use JSONP here, the object passed into `updateState` is a parsed JSON object actually. Continue to use `data` as the variable name here is a bit confuse. I change `data` to `state` now. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review143849 ----------------------------------------------------------- On July 29, 2016, 4:24 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50482/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 4:24 a.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Lunøe, Vinod Kone, and > Jiang Yan Xu. > > > Bugs: MESOS-5911 > https://issues.apache.org/jira/browse/MESOS-5911 > > > Repository: mesos > > > Description > ------- > > The redirection in WEB UI is broken since the CORS restriction after > we enabled redirection in `master/state` endpoint in > https://reviews.apache.org/r/34646/. We change the request way to > `master/state` endpoint from xhr to jsonp for bypassing the CORS > restriction. > > > Diffs > ----- > > src/webui/master/static/index.html a083537cd718162d1913842bddbd2653d8c52337 > src/webui/master/static/js/controllers.js > ceaf1402ebdae4efd1a8a6fc9c7b795de69e2fc0 > > Diff: https://reviews.apache.org/r/50482/diff/ > > > Testing > ------- > > Testing video record > >  > > > Thanks, > > haosdent huang > >
