----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/#review144221 -----------------------------------------------------------
Ship it! src/webui/master/static/js/controllers.js (lines 375 - 378) <https://reviews.apache.org/r/50482/#comment210223> Committing with minor comment tweaking ``` // When the current master is not the leader, the request is redirected to // the leading master automatically. This would cause a CORS error if we // use XMLHttpRequest here. To avoid the CORS error, we use JSONP as a // workaround. Please refer to MESOS-5911 for further details. ``` - Jiang Yan Xu On July 29, 2016, 12:02 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50482/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 12:02 a.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Lunøe, Vinod Kone, and > Jiang Yan Xu. > > > Bugs: MESOS-5911 > https://issues.apache.org/jira/browse/MESOS-5911 > > > Repository: mesos > > > Description > ------- > > The redirection in WEB UI is broken since the CORS restriction after > we enabled redirection in `master/state` endpoint in > https://reviews.apache.org/r/34646/. We change the request way to > `master/state` endpoint from xhr to jsonp for bypassing the CORS > restriction. > > > Diffs > ----- > > src/webui/master/static/index.html a083537cd718162d1913842bddbd2653d8c52337 > src/webui/master/static/js/controllers.js > ceaf1402ebdae4efd1a8a6fc9c7b795de69e2fc0 > > Diff: https://reviews.apache.org/r/50482/diff/ > > > Testing > ------- > > Testing video record > >  > > > Thanks, > > haosdent huang > >
