----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review144424 -----------------------------------------------------------
src/tests/cmake/MesosTestsConfigure.cmake (line 74) <https://reviews.apache.org/r/49688/#comment210446> I have mentioned this before, but I think it makes sense to refactor `CONTAINERIZER_TEST_*` variables to simply depend on `MESOS_TESTS_*` variables. What do you think? I think it makes things cleaner and simpler in the end, since they both depend on libmesos, which is pretty monolithic. src/tests/cmake/MesosTestsConfigure.cmake (line 76) <https://reviews.apache.org/r/49688/#comment210442> This variable doesn't seem to exist. Did you mean the (eminently badly named) `AGENT_DEPENDENCIES`? src/tests/cmake/MesosTestsConfigure.cmake (line 92) <https://reviews.apache.org/r/49688/#comment210441> Why `MASTER_INCLUDE_DIRS` here? Seems like we should be including the poorly-named `AGENT_INCLUDE_DIRS` instead? src/tests/cmake/MesosTestsConfigure.cmake (line 109) <https://reviews.apache.org/r/49688/#comment210443> This variable also doesn't exist? src/tests/cmake/MesosTestsConfigure.cmake (line 129) <https://reviews.apache.org/r/49688/#comment210440> Seems like there should be a blank line here? - Alex Clemmer On July 19, 2016, 9:35 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49688/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 9:35 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added cmake build variables for mesos tests. > > > Diffs > ----- > > src/tests/cmake/MesosTestsConfigure.cmake > caecce14ca884dcc09ae4ba7649a09f7ae7c1fdf > src/tests/containerizer/CMakeLists.txt > 41e792a2c9ec588d4897d60d012e67c606bbe601 > > Diff: https://reviews.apache.org/r/49688/diff/ > > > Testing > ------- > > cmake .. > cmake check > > > Thanks, > > Srinivas Brahmaroutu > >
