----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144633 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/50723/#comment210657> Seems like we should still be logging when we get a status update from an unknown framework. src/master/master.cpp (line 5153) <https://reviews.apache.org/r/50723/#comment210661> `getFramework()` might return non-`nullptr` for a disconnected (but still registered) framework, so I think you should rephrase this. src/master/master.cpp (line 5175) <https://reviews.apache.org/r/50723/#comment210656> Should we call such a status update "valid"? We didn't before, now we will. Not sure new behavior is wrong but seems worth discussing. src/tests/master_tests.cpp (line 4665) <https://reviews.apache.org/r/50723/#comment210662> Should we also check that the task correctly transitions to a terminal state in the master? - Neil Conway On Aug. 2, 2016, 9:45 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50723/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 9:45 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5930 > https://issues.apache.org/jira/browse/MESOS-5930 > > > Repository: mesos > > > Description > ------- > > The master's status handler function used to ignore the status updates > from the agents for frameworks not yet re-connected with the master > upon a failover. This change modifies that logic to still update > the local state and not bail out early. > > > Diffs > ----- > > src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c > src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b > > Diff: https://reviews.apache.org/r/50723/diff/ > > > Testing > ------- > > make check (gtest_repeat=100) > > > Thanks, > > Anand Mazumdar > >
