----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/#review144677 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp (lines 5201 - 5203) <https://reviews.apache.org/r/50723/#comment210718> How about // The task might not exist in master's memory (e.g., failed task validation). src/master/master.cpp (lines 5206 - 5209) <https://reviews.apache.org/r/50723/#comment210719> I think this part of the comment is a bit confusing. I would just kill it. Keep the last sentence "Note that master..." src/tests/master_tests.cpp (line 4795) <https://reviews.apache.org/r/50723/#comment210720> i.e., src/tests/master_tests.cpp (line 4824) <https://reviews.apache.org/r/50723/#comment210721> s/send a retry/retry/ - Vinod Kone On Aug. 3, 2016, 8:44 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50723/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2016, 8:44 p.m.) > > > Review request for mesos, Adam B, Neil Conway, and Vinod Kone. > > > Bugs: MESOS-5930 > https://issues.apache.org/jira/browse/MESOS-5930 > > > Repository: mesos > > > Description > ------- > > The master's status handler function used to ignore the status updates > from the agents for frameworks not yet re-connected with the master > upon a failover. This change modifies that logic to still update > the local state and not bail out early. > > > Diffs > ----- > > src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c > src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b > > Diff: https://reviews.apache.org/r/50723/diff/ > > > Testing > ------- > > make check (gtest_repeat=100) > > > Thanks, > > Anand Mazumdar > >
