----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50699/#review145016 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto (line 309) <https://reviews.apache.org/r/50699/#comment211171> s/most/more/ ? include/mesos/mesos.proto (line 314) <https://reviews.apache.org/r/50699/#comment211172> since strict registry is no longer configurable, how about "(unless the master has failed over)" ? include/mesos/mesos.proto (lines 1429 - 1456) <https://reviews.apache.org/r/50699/#comment211173> Great comments! Suggestion: Instead of clubbing the comments of all new statuses, it would be nice to put them on top of each new field. You can have a new line after #1428 to indicate that the comment applies to all the below statuses. include/mesos/v1/mesos.proto (line 1455) <https://reviews.apache.org/r/50699/#comment211174> ditto. see above. src/master/master.cpp (lines 6892 - 6893) <https://reviews.apache.org/r/50699/#comment211175> not yours, but lets not have a default case (have an explicit TASK_UNKNOWN case that is a no-op) here so that people don't forget to update this in the future when they add new statuses. - Vinod Kone On Aug. 2, 2016, 1 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50699/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 1 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-4049 > > > Repository: mesos > > > Description > ------- > > TASK_DROPPED, TASK_UNREACHABLE, TASK_GONE, TASK_GONE_BY_OPERATOR, and > TASK_UNKNOWN. These values are intended to replace the existing > TASK_LOST state by offering more fine-grained information on the > current state of a task. These states will only be sent to frameworks > that opt into this new behavior via the PARTITION_AWARE capability. > > Note that this commit doesn't add a master metric for the TASK_UNKNOWN > status, because this is a "default" status reported when the master has > no knowledge of a particular task/agent ID. Hence the number of > "unknown" tasks at any given time is not a well-defined metric. > > > Diffs > ----- > > include/mesos/mesos.proto 590e169108b2ce5881734ec7f4b01cef9937461a > include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 > src/common/protobuf_utils.cpp 8c4a7264080385789157703b05b42716fb0563b3 > src/examples/disk_full_framework.cpp > ad304fee94d443125a0dec2b2820267c69508621 > src/master/http.cpp e26dc2ff19fdfebc4d57009f355ebc92df3b62fd > src/master/master.cpp 060dc7f9730808c7fd9b8f9ecdbde0aac14d135c > src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 > src/master/metrics.cpp 88a752dc2b4b73ccb919e99478b9ea2bd83842a0 > src/tests/master_tests.cpp 6709818d599c068c289bcb714446018577082d8b > > Diff: https://reviews.apache.org/r/50699/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
