> On Aug. 6, 2016, 12:29 a.m., Vinod Kone wrote: > > src/local/local.cpp, lines 179-180 > > <https://reviews.apache.org/r/50003/diff/7/?file=1448796#file1448796line179> > > > > not sure if 'propagated_flags' is the right name. > > > > also, wondering if it would be intuitive to just do > > > > os::setenv("MESOS_WORK_DIR") = flags.work_dir; > > Ammar Askar wrote: > >not sure if 'propagated_flags' is the right name. > > The reasoning was they are being propogated from the local main()'s flags > to the agent's and master's flags. > > > >also, wondering if it would be intuitive to just do > > That would certainly work, the reason I didn't do it that way and opted > to take the approach with the map is to make this more extensible in the > future. So in case more flags need to be added to the local run. And if they > only needed to be provided to a master or just the agents, it's much easier > and clearer than fiddling with environment variables, in my opinion.
sgtm. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review145011 ----------------------------------------------------------- On July 21, 2016, 1:38 a.m., Ammar Askar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50003/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 1:38 a.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5613 > https://issues.apache.org/jira/browse/MESOS-5613 > > > Repository: mesos > > > Description > ------- > > Propagate work_dir flag from local runs to agents/masters. > > > Diffs > ----- > > src/local/flags.hpp f0af0d2 > src/local/local.cpp a543aef > > Diff: https://reviews.apache.org/r/50003/diff/ > > > Testing > ------- > > Manually tested that `mesos local` and `mesos-local` run now. Not sure if a > regression test for this would be good, please advise. > > > Thanks, > > Ammar Askar > >
