----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142973 -----------------------------------------------------------
src/local/flags.hpp (line 50) <https://reviews.apache.org/r/50003/#comment208626> Hi Ammar: sorry for the extra comment here, but I actually just discovered the helper function `os::temp()`. We use it [here](https://github.com/apache/mesos/blob/master/src/slave/flags.cpp#L129). Since it looks like this is our accepted way to set default temporary locations, we should follow that pattern here as well. - Greg Mann On July 20, 2016, 5:10 a.m., Ammar Askar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50003/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 5:10 a.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5613 > https://issues.apache.org/jira/browse/MESOS-5613 > > > Repository: mesos > > > Description > ------- > > Propagate work_dir flag from local runs to agents/masters. > > > Diffs > ----- > > src/local/flags.hpp f0af0d2 > src/local/local.cpp a543aef > > Diff: https://reviews.apache.org/r/50003/diff/ > > > Testing > ------- > > Manually tested that `mesos local` and `mesos-local` run now. Not sure if a > regression test for this would be good, please advise. > > > Thanks, > > Ammar Askar > >
