----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review145651 -----------------------------------------------------------
Patch looks great! Reviews applied: [50266, 50889, 51042, 51043, 50269, 50270, 50271] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 12, 2016, 4:48 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50271/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 4:48 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5275 > https://issues.apache.org/jira/browse/MESOS-5275 > > > Repository: mesos > > > Description > ------- > > This isolator evaluates agent allowed capabilities and passes net > capabilities on to `mesos-containerizer` which enforces the > capabilities. > > Capability information is passed via a new field in > `ContainerLaunchInfo`. > > > Diffs > ----- > > include/mesos/slave/isolator.proto e945514fbdd49b3b35e200a7fc2e1cd446c1af91 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/containerizer.cpp > 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 > src/slave/containerizer/mesos/isolators/capabilities.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/capabilities.cpp PRE-CREATION > src/tests/containerizer/isolator_tests.cpp > 4f047ae6b2e85e177e8b73d60b9dfca913c832a5 > > Diff: https://reviews.apache.org/r/50271/diff/ > > > Testing > ------- > > `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o > optimizations) > > > Thanks, > > Benjamin Bannier > >