> On Aug. 8, 2016, 11:17 p.m., Qian Zhang wrote: > > > > haosdent huang wrote: > Hi, @qianzhang Because I think all the test cases are associate with > `CgroupsIsolator`, I think it would be better to update the test cases name > to make it more clear and exactly.
@haosdent, I agree we should change `RevocableCpuIsolatorTest` to `CgroupsIsolatorTest`, but I think we may not need to change the test name `ROOT_CGROUPS_RevocableCpu` to `ROOT_CGROUPS_CpuSubsystemRevocable`, `CpuSubsystem` is the name of an internal component, I think it may be better to not include it in the name of a test. Usually the name should describe a scenario that we want to test. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/#review145106 ----------------------------------------------------------- On Aug. 11, 2016, 10:20 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50733/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 10:20 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5973 > https://issues.apache.org/jira/browse/MESOS-5973 > > > Repository: mesos > > > Description > ------- > > Removed CgroupsCpushareIsolatorProcess. > > > Diffs > ----- > > src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 > src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c > src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 > src/slave/containerizer/mesos/containerizer.cpp > 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 > src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp > 74982a610b6c0a74734165a0c6aa8c9f72f54deb > src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp > 221e814a448c4b5df9dab98de597451a24e2b89c > src/tests/containerizer/isolator_tests.cpp > 4f047ae6b2e85e177e8b73d60b9dfca913c832a5 > > Diff: https://reviews.apache.org/r/50733/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
