> On Aug. 13, 2016, 8:07 p.m., Neil Conway wrote: > > Hi Aaron, > > > > Awesome, thanks for your contribution! Two quick suggestions: > > > > (1) Is there a workload/tool that repros the memory leak? e.g., it would be > > good to be able to say that "when you do X (e.g., run unit test X) under > > `valgrind --leak-check=full`, there was previously a memory leak of X > > bytes; with these changes, the leak is instead Y bytes." > > > > (2) When contributing to Mesos, we try to encourage people to find a > > shepherd (Mesos committer) to work with to get your changes committed > > (https://mesos.apache.org/documentation/latest/submitting-a-patch/). I've > > pinged a few committers, so hopefully someone volunteers -- otherwise, you > > can find people in the `#dev` channel on Slack, IRC, or the dev mailing > > list.
You're welcome! :) Yeah, I found these with the help of cppcheck. I did not check with valgrind though I can do some more testing with that if you'd like. Thanks for helping me find a shepherd! I'll check on Slack/IRC tomorrow if I don't hear from anyone. I've already emailed the mailing list. FYI I did open a ticket for this here https://issues.apache.org/jira/browse/MESOS-6038 as well as a PR here https://github.com/apache/mesos/pull/157. I think I should have only added myself to the contributiors file though which was my mistake. - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/#review145706 ----------------------------------------------------------- On Aug. 13, 2016, 8:08 a.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51068/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2016, 8:08 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > This should prevent any of the promises that are created in the various > ZookeeperProcess class methods from leaking memory. > > > Diffs > ----- > > docs/contributors.yaml 3f06000 > src/zookeeper/zookeeper.cpp e105377 > > Diff: https://reviews.apache.org/r/51068/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Aaron Wood > >
