----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/#review145930 -----------------------------------------------------------
Hey Aaron, I was not able to identify the leaks you were addressing. Also there seems to be some object lifetime issues introduced with this patch. src/zookeeper/zookeeper.cpp (lines 193 - 214) <https://reviews.apache.org/r/51068/#comment212280> Promise is now on the stack here, but the asynchronous callbacks (voidCompletion, stringCompletion, statCompletion, dataCompletion) need to access the promise to satisfy the future. There doesn't appear to have been a leak here in that the callbacks (voidCompletion, stringCompletion, statCompletion, dataCompletion) delete the promise after satisfying it. Can you add more detail as to why you're making this change? - Benjamin Mahler On Aug. 13, 2016, 8:08 a.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51068/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2016, 8:08 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > This should prevent any of the promises that are created in the various > ZookeeperProcess class methods from leaking memory. > > > Diffs > ----- > > docs/contributors.yaml 3f06000 > src/zookeeper/zookeeper.cpp e105377 > > Diff: https://reviews.apache.org/r/51068/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Aaron Wood > >
