----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review145865 -----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp (line 1232) <https://reviews.apache.org/r/50751/#comment212230> I think changing test name from `ROOT_CGROUPS_PERF_Sample` to `ROOT_CGROUPS_PERF_PerfEventSample` will make this test fail, I have verfied in Ubuntu 14.04: ``` [ RUN ] CgroupsIsolatorTest.ROOT_CGROUPS_PERF_PerfEventSample ../../src/tests/containerizer/isolator_tests.cpp:1244: Failure _isolator: Failed to create subsystem 'perf_event': Failed to create subsystem 'perf_event': Perf is not supported [ FAILED ] CgroupsIsolatorTest.ROOT_CGROUPS_PERF_PerfEventSample (68 ms) ``` Basically this test should be disabled in Ubuntu 14.04, please take a look at the following code about why it is not disabled when the test name is changed: https://github.com/apache/mesos/blob/0d3793e94adcd6dc91d06404f205639cebd753fd/src/tests/environment.cpp#L588:L596 - Qian Zhang On Aug. 15, 2016, 9:12 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50751/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 9:12 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5975 > https://issues.apache.org/jira/browse/MESOS-5975 > > > Repository: mesos > > > Description > ------- > > Removed CgroupsPerfEventIsolatorProcess. > > > Diffs > ----- > > src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/containerizer.cpp > 5ed894d18258f6516866a2acd343c03281039c3c > src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp > 4abde12af68a26b94b3706cdb38bf9890d811039 > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp > 31f35385691681ef5da14be747edfb5f57c5d05a > src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp > PRE-CREATION > src/tests/containerizer/isolator_tests.cpp > f917db78157f799efc00b0c7af0230ddb6f26b0b > > Diff: https://reviews.apache.org/r/50751/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
