----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review145966 -----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp (line 1235) <https://reviews.apache.org/r/50751/#comment212322> Why renaming this test from `ROOT_CGROUPS_PERF_Sample` to `ROOT_CGROUPS_PERF_PerfEventSample`? Can we just keep the original test name `ROOT_CGROUPS_PERF_Sample`? And then in `src/tests/environment.cpp`, I think you only need to remove the duplicated `matches(test, "ROOT_CGROUPS_PERF_Sample")`. - Qian Zhang On Aug. 17, 2016, 1:47 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50751/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 1:47 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5975 > https://issues.apache.org/jira/browse/MESOS-5975 > > > Repository: mesos > > > Description > ------- > > Removed CgroupsPerfEventIsolatorProcess. > > > Diffs > ----- > > src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/containerizer.cpp > 5ed894d18258f6516866a2acd343c03281039c3c > src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp > 4abde12af68a26b94b3706cdb38bf9890d811039 > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp > 31f35385691681ef5da14be747edfb5f57c5d05a > src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp > PRE-CREATION > src/tests/containerizer/isolator_tests.cpp > f917db78157f799efc00b0c7af0230ddb6f26b0b > src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 > > Diff: https://reviews.apache.org/r/50751/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
