----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51122/ -----------------------------------------------------------
(Updated Aug. 16, 2016, 11:43 a.m.) Review request for mesos, Benjamin Mahler, Greg Mann, Artem Harutyunyan, and Vinod Kone. Changes ------- Changed approach. From `delete` to guarding with a check. Repository: mesos Description (updated) ------- This leak was introduced on purpose in: https://reviews.apache.org/r/34016/ When we run tests in repetition, each agent will create a new signal handler and leak the old one. This patch moves the signal handler code into the agent's `main()` function and guards the signal handler helper with a check. Diffs (updated) ----- src/slave/main.cpp 8c9d241890ffa85f88096385e07789e6fc945ddb src/slave/posix_signalhandler.hpp 4a5411793e55f912c6e8ae72f9a8042d3a6195b5 src/slave/slave.hpp 9f29d80182210357e0b85d8c69e9fd7e46ef94f2 src/slave/slave.cpp 0feb5c5b6498fe2627a9239b2c1aea78f1c57e49 src/slave/windows_ctrlhandler.hpp 9481e0f6271031d13ac6d1759372d466f52f8de5 Diff: https://reviews.apache.org/r/51122/diff/ Testing (updated) ------- Found this leak via code inspection after valgrind. make check (OSX) bin/mesos-agent.sh --work_dir=/tmp/agent --master=localhost:5050 kill -SIGUSR1 <agent pid> Saw the appropriate line in the log: `slave.cpp:800] Received SIGUSR1 signal from user <me>; shutting down Thanks, Joseph Wu
