----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51122/#review145906 -----------------------------------------------------------
Fix it, then Ship it! src/slave/posix_signalhandler.hpp (lines 22 - 23) <https://reviews.apache.org/r/51122/#comment212263> Well calling concurrently from multiple threads seems bad? We don't have synchronization. src/slave/windows_ctrlhandler.hpp (lines 24 - 25) <https://reviews.apache.org/r/51122/#comment212264> Ditto here. - Benjamin Mahler On Aug. 16, 2016, 7:40 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51122/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 7:40 p.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, Artem Harutyunyan, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This leak was introduced on purpose in: > https://reviews.apache.org/r/34016/ > > When we run tests in repetition, each agent will create a new signal > handler and leak the old one. This patch frees the old signal handler > and fixes up some related comments, because the behavior of calling the > signal handler helper multiple times is predicable. > > Also fixes a related typo. > > > Diffs > ----- > > src/slave/posix_signalhandler.hpp 4a5411793e55f912c6e8ae72f9a8042d3a6195b5 > src/slave/slave.cpp 0feb5c5b6498fe2627a9239b2c1aea78f1c57e49 > src/slave/windows_ctrlhandler.hpp 9481e0f6271031d13ac6d1759372d466f52f8de5 > > Diff: https://reviews.apache.org/r/51122/diff/ > > > Testing > ------- > > Found this leak via code inspection after valgrind. > > make check (OSX) > > bin/mesos-agent.sh --work_dir=/tmp/agent --master=localhost:5050 > kill -SIGUSR1 <agent pid> > Saw the appropriate line in the log: `slave.cpp:800] Received SIGUSR1 signal > from user <me>; shutting down > > bin/mesos-tests.sh --gtest_filter="*SIGUSR1*" --gtest_repeat=100 > > > Thanks, > > Joseph Wu > >
