----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review145881 -----------------------------------------------------------
Can you split the change to the cgroups library and the cgroups isolator? src/linux/cgroups.hpp (line 220) <https://reviews.apache.org/r/51031/#comment212245> Use the following so it's more clear what "nested cgroups" mean? ``` @param recursive Whether to recursively retrive descendants under the children of `cgroup`. ``` src/linux/cgroups.cpp (line 920) <https://reviews.apache.org/r/51031/#comment212259> s/0/FTS_ROOTLEVEL/ src/linux/cgroups.cpp (lines 920 - 921) <https://reviews.apache.org/r/51031/#comment212266> I think it's simpler and more efficient to actually skip traversing the subtree. Could you use something like this? ``` if (!recursive && node->fts_level > FTS_ROOTLEVEL) { fts_set(tree, node, FTS_SKIP); } ``` - Jiang Yan Xu On Aug. 15, 2016, 11:04 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51031/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 11:04 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-6035 > https://issues.apache.org/jira/browse/MESOS-6035 > > > Repository: mesos > > > Description > ------- > > Added non-recursive version of `cgroups::get`. > > > Diffs > ----- > > src/linux/cgroups.hpp 047d3ea596660e704447c0f0c7b914a43c4a2187 > src/linux/cgroups.cpp f3232c009d04bb82701c0407b12abf999ab60a73 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 7e205a3eea4ad89faccf564bdb2ad0041fdee249 > > Diff: https://reviews.apache.org/r/51031/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
