----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review145834 -----------------------------------------------------------
src/linux/cgroups.hpp (line 218) <https://reviews.apache.org/r/51031/#comment212189> You may also need to update the comments of this method for the parameters. src/linux/cgroups.cpp (lines 918 - 919) <https://reviews.apache.org/r/51031/#comment212191> I think this code should be moved into the `if` block below. src/linux/cgroups.cpp (line 923) <https://reviews.apache.org/r/51031/#comment212190> Should the second `&&` be `||`? - Qian Zhang On Aug. 15, 2016, 9:08 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51031/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 9:08 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-6035 > https://issues.apache.org/jira/browse/MESOS-6035 > > > Repository: mesos > > > Description > ------- > > Added non-recursive version of `cgroups::get`. > > > Diffs > ----- > > src/linux/cgroups.hpp 047d3ea596660e704447c0f0c7b914a43c4a2187 > src/linux/cgroups.cpp f3232c009d04bb82701c0407b12abf999ab60a73 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 7e205a3eea4ad89faccf564bdb2ad0041fdee249 > > Diff: https://reviews.apache.org/r/51031/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
