----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51173/#review145987 -----------------------------------------------------------
Patch looks great! Reviews applied: [51141, 51170, 51171, 51172, 51173] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 17, 2016, 8:44 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51173/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 8:44 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem > Harutyunyan, Jie Yu, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > [WIP] DO NOT MERGE. > > This patch includes: > 1. Plugged in the volume/image isolator. > 2. Changed MesosContainerizerProcess interface. The parameter for > provisioner is changed from an owned pointer to a shared pointer. > 3. Fixed corresponding unit tests. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 499396121de4e9e654f78f73493e76053fb83d42 > src/slave/containerizer/mesos/containerizer.cpp > 77a502f853e3e04ea8e274419544601778be9421 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 6bf9a4a6438697657750f62980480205c558b6cc > src/tests/containerizer/filesystem_isolator_tests.cpp > 2b216c3fd2cf01b8b43a262795257ae65af8af2f > src/tests/containerizer/mesos_containerizer_tests.cpp > 4a49247a8b8c6995535a865266f85f2aa31fb4de > > Diff: https://reviews.apache.org/r/51173/diff/ > > > Testing > ------- > > make check > > Currently `ROOT_RecoverOrphanedPersistentVolume` still leak a provisioner > object because of orphaned container. Should not be related to the code base. > Will fix this unit test. > > > Thanks, > > Gilbert Song > >
