----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51173/#review146289 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/filesystem/linux.cpp (line 378) <https://reviews.apache.org/r/51173/#comment212663> I'd ``` VLOG(1) << "Ignored an image volume for container ... ``` - Jie Yu On Aug. 22, 2016, 2:14 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51173/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 2:14 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem > Harutyunyan, Jie Yu, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch includes: > 1. Plugged in the volume/image isolator. > 2. Changed MesosContainerizer interface. The parameter for > provisioner is changed from an owned pointer to a shared > pointer. > 3. Fixed corresponding unit tests. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 499396121de4e9e654f78f73493e76053fb83d42 > src/slave/containerizer/mesos/containerizer.cpp > 77a502f853e3e04ea8e274419544601778be9421 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > 6bf9a4a6438697657750f62980480205c558b6cc > src/tests/container_logger_tests.cpp > efadceafca5721bce4dbffadb35f54fd5365abb0 > src/tests/containerizer/docker_volume_isolator_tests.cpp > da96f8646874df31729783416ab9bfad282696c7 > src/tests/containerizer/filesystem_isolator_tests.cpp > 2b216c3fd2cf01b8b43a262795257ae65af8af2f > src/tests/containerizer/mesos_containerizer_tests.cpp > 4a49247a8b8c6995535a865266f85f2aa31fb4de > > Diff: https://reviews.apache.org/r/51173/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
