----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51043/#review146024 -----------------------------------------------------------
src/linux/capabilities.cpp (lines 229 - 231) <https://reviews.apache.org/r/51043/#comment212378> Hum, this is not very performant. If lastCap == 37, a single get() here will issue 37 system calls. Can you at least add a TODO to address it. Looks like other library reads `/proc/self/status`: https://github.com/syndtr/gocapability/blob/master/capability/capability_linux.go#L390-L414 - Jie Yu On Aug. 12, 2016, 4:47 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51043/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 4:47 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5051 > https://issues.apache.org/jira/browse/MESOS-5051 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/capabilities.cpp 5f21dd42dd94af907450aabb1900d1f73816b31c > > Diff: https://reviews.apache.org/r/51043/diff/ > > > Testing > ------- > > make check and sudo make check (Debian jessie, gcc-4.9.2, w/o optimizations) > > > Thanks, > > Benjamin Bannier > >
