> On Aug. 17, 2016, 8:20 p.m., Jie Yu wrote: > > src/linux/capabilities.cpp, lines 229-231 > > <https://reviews.apache.org/r/51043/diff/1/?file=1472103#file1472103line229> > > > > Hum, this is not very performant. If lastCap == 37, a single get() here > > will issue 37 system calls. Can you at least add a TODO to address it. > > > > Looks like other library reads `/proc/self/status`: > > > > https://github.com/syndtr/gocapability/blob/master/capability/capability_linux.go#L390-L414
I left the implementation as is for the moment as it has a very limited set of error cases. I added a `TODO` to possibly add a more performant implementation at a later point. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51043/#review146024 ----------------------------------------------------------- On Aug. 25, 2016, 5:18 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51043/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 5:18 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-5051 > https://issues.apache.org/jira/browse/MESOS-5051 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/capabilities.cpp e58cb981f9cf7880524114e94ba42cbacfe45630 > > Diff: https://reviews.apache.org/r/51043/diff/ > > > Testing > ------- > > make check and sudo make check (Debian jessie, gcc-4.9.2, w/o optimizations) > > > Thanks, > > Benjamin Bannier > >
