----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51155/#review146246 -----------------------------------------------------------
Can you rebase? The diff is not correct. - Jie Yu On Aug. 20, 2016, 8:54 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51155/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2016, 8:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-6050 > https://issues.apache.org/jira/browse/MESOS-6050 > > > Repository: mesos > > > Description > ------- > > Currently, a number of agent components hard code a path > under '/var/run/mesos' in order to persist runtime information across > agent crashes. This path should be configurable. > > This commit adds an agent flag to make this runtime directory > configurable. It only lays the groundwork for migrating all of the > hard coded paths. It doesn't actually modify these components yet. > That will come in subsequent commits. > > > Diffs > ----- > > include/mesos/type_utils.hpp d10b66345e1a70801050d2cf2db63d76fbf9bc8c > include/mesos/version.hpp.in 63b6d95f9c29435ab8743e3369d85386a0e46b69 > src/CMakeLists.txt 85eb2b855e87d432b9f9c9baa9a5b243928547f7 > src/Makefile.am d0f937d8879b11fac793b73f529762e95a9ff1e4 > src/common/parse.hpp 51582a4f8943296799d71d0a8d7812787fd1b2c2 > src/common/type_utils.cpp c7d50334b4e56bc0eb5473b9f9277465b607334f > src/docker/spec.cpp 2f2c32e9b7d78debb31dcc1aa91a4d45c1ced192 > src/slave/constants.hpp 360dd059b21ae3128766ba7abdbffb36d4c3ec13 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 1b84a561cd9498b85d03e901c4372e4f1293f185 > src/slave/containerizer/mesos/isolators/cgroups/constants.hpp > 3146cc6ee8532f7bd2a98881d0dc9c9cf5c607df > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp > 06f4400966ba467623556901b38d12e69fbbbd04 > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp > 9789cf6a0f87eef5293331832369e6fb46e417e4 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp > c1f1004d7578f59dfa9e28323e7a55df41c4cb6b > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp > 5912c6504a375178b892bf8099d5f75fa9e91c05 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuacct.hpp > 10fbbc9cb39a3b41d64cc090b0e890a2416b2306 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpuacct.cpp > a35ecb073acefb903d7e8c4737d6cd048a2b494d > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 74ffcf5d9899c00b59958897fc9475347fd91160 > src/slave/flags.hpp ef2394cae5cb72ae627aaef443ac06a50bcfb16f > src/slave/flags.cpp c07d6e5e062b75c9dd867e3dced9e2cc8b69872d > src/tests/balloon_framework_test.sh > 5d013fca1fb21b9242debb856b94136655dae4d5 > src/tests/containerizer/docker_spec_tests.cpp > 82bddd228df3db95a00eb277ff9c380039b70b1e > src/tests/containerizer/xfs_quota_tests.cpp > d0f5032a40686af45320eeb66ea6a6a95d5b3ff6 > src/tests/disk_full_framework_test.sh > 7b84d81ee8b2a88b199eef7beb86b13cfba566b0 > src/tests/dynamic_reservation_framework_test.sh > 5e664c8c0fa0285fa22583d900cfde9b54ab86cd > src/tests/java_exception_test.sh fdafc4587e1f697e66d934d65f746a45fac68555 > src/tests/java_framework_test.sh b2d748162c71e2e23f26470e16f922c1458bf9ec > src/tests/java_v0_framework_test.sh > 12daae4ecd21a21645d101eae0d6470c7bcf4026 > src/tests/java_v1_framework_test.sh > c49e11cbebb525db05cb6d88f7de7ee32880ab36 > src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 > src/tests/no_executor_framework_test.sh > 29c952da31d90bd824393d4791d9db857b2724d1 > src/tests/persistent_volume_framework_test.sh > 6a807193f72c77216e8f3680a7606e9022255bc9 > src/tests/python_framework_test.sh 74427b4a49e5b172815ddb7e8d6248d3b8a9539a > src/tests/test_framework_test.sh 73b4ddc375466755e6e94bed2a340a76f806f787 > src/tests/test_http_framework_test.sh > b7242038fbc9551bd8e6f048780cf23dbf40b6e1 > > Diff: https://reviews.apache.org/r/51155/diff/ > > > Testing > ------- > > make -j check > sudo src/mesos-tests > Currently running through CI > > > Thanks, > > Kevin Klues > >
