----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review146248 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 142 - 146) <https://reviews.apache.org/r/49851/#comment212602> Hum, i don't like this approach. Can you introduce a `Subsystem::watch` method: ``` Future<ContainerLimitation> Subsystem::watch( const ContainerID& containerId); ``` In the cgroups isolator `watch` method, simply invoke `subsystem->watch`. ``` subsystem->watch(containerId) .onAny(defer(self(), &Self::_watch, ...)); void CgroupsIsolatorProcses::_watch(...) { if (!infos.contains(containerId)) { return; } infos[containerId]->limiation.set(limitation); } ``` - Jie Yu On Aug. 20, 2016, 9:20 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49851/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2016, 9:20 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5045 > https://issues.apache.org/jira/browse/MESOS-5045 > > > Repository: mesos > > > Description > ------- > > Implemented `MemorySubsystem`. > > > Diffs > ----- > > src/CMakeLists.txt a83dde9f51e5601d02be6c233b1fcd5bee324ba1 > src/Makefile.am bfda83d112149cd3e5c579a33252e463212a9c5b > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 9b2d33ec3b023058d00c6671464cc9cd092f653b > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > cae642a8af8e45fdaa868826f48b9abcfd9bbd7f > src/slave/containerizer/mesos/isolators/cgroups/constants.hpp > cc402b4d5437c085e7fef1ff8207b5032c779e1e > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp > 06f4400966ba467623556901b38d12e69fbbbd04 > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp > 767c56d8fc8717d6a35bc5483d8b12b866d85e21 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/49851/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
