----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/#review146350 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 43) <https://reviews.apache.org/r/51096/#comment212736> Why do we need this variable? I do not see it is used in the code below. src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (line 51) <https://reviews.apache.org/r/51096/#comment212732> I think we do not this newline, we usually add a newline after a multi-line code. src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp (lines 52 - 77) <https://reviews.apache.org/r/51096/#comment212747> Can we simplify these code to something like below? ``` while(input.isSome()) { config += input.get(); input = os::read(STDIN_FILENO, STDIN_READ_LENGTH); } if (input.isError()) { cniError.set_msg("Unable to read STDIN: " + input.error()); cout << JSON::protobuf(cniError) << endl; return EXIT_FAILURE; } ``` - Qian Zhang On Aug. 16, 2016, 2:48 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51096/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 2:48 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > The `mesos-port-mapper` is a CNI plugin that can be used to install > port-forwarding rules for a container. The `mesos-port-mapper` is a > wrapper CNI plugin that should always be used in conjunction with > other CNI plugins. > > > Diffs > ----- > > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/51096/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
