> On Aug. 26, 2016, 7:10 p.m., Jie Yu wrote: > > src/Makefile.am, line 1345 > > <https://reviews.apache.org/r/51096/diff/4/?file=1486413#file1486413line1345> > > > > mesos-cni-port-mapper? > > > > Port mapper sounds too general to me.
Agreed. I was also a bit doubtful about using port-mapper as is. > On Aug. 26, 2016, 7:10 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp, > > line 48 > > <https://reviews.apache.org/r/51096/diff/4/?file=1486414#file1486414line48> > > > > We should introduce a stout read function to read an fd till EOF > > (similar to read(path)). Can you add a TODO here? Will do. > On Aug. 26, 2016, 7:10 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp, > > lines 43-46 > > <https://reviews.apache.org/r/51096/diff/4/?file=1486414#file1486414line43> > > > > Any reason you want to initialize the error here, instead of below > > where you set the error message? There were multiple places were we were return the error, and the version and error codes are fixed, for these errors (at least within the main). Hence, was initializing it once. Don't mind initializing it where we actually need it. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/#review147004 ----------------------------------------------------------- On Aug. 26, 2016, 12:29 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51096/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 12:29 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > The `mesos-port-mapper` is a CNI plugin that can be used to install > port-forwarding rules for a container. The `mesos-port-mapper` is a > wrapper CNI plugin that should always be used in conjunction with > other CNI plugins. > > > Diffs > ----- > > src/Makefile.am 120a715eeeb7fb222d1169500950b5c7643df554 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/51096/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
