----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51163/#review146377 -----------------------------------------------------------
Ship it! Will come back to make another pass for this patch. - Gilbert Song On Aug. 21, 2016, 9:39 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51163/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2016, 9:39 p.m.) > > > Review request for mesos, Benjamin Hindman, Gilbert Song, Kevin Klues, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch simplified the MesosContainerizer logic by introducing > `ContainerConfig` in `Container` struct. This avoids some parameter > passing in the launch path. To prepare for the nested container > support, this patch introduces a private `launch` method which takes a > `ContainerConfig` (instead of ExecutorInfo and TaskInfo) since nested > container might not tie to a task. > > > Diffs > ----- > > include/mesos/slave/isolator.proto e945514fbdd49b3b35e200a7fc2e1cd446c1af91 > src/slave/containerizer/mesos/containerizer.hpp > 499396121de4e9e654f78f73493e76053fb83d42 > src/slave/containerizer/mesos/containerizer.cpp > 77a502f853e3e04ea8e274419544601778be9421 > src/tests/containerizer/mesos_containerizer_tests.cpp > 4a49247a8b8c6995535a865266f85f2aa31fb4de > > Diff: https://reviews.apache.org/r/51163/diff/ > > > Testing > ------- > > > Thanks, > > Jie Yu > >
