----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50000/#review146439 -----------------------------------------------------------
Ship it! Will commit with the following edits. src/tests/slave_tests.cpp (lines 282 - 284) <https://reviews.apache.org/r/50000/#comment212962> I removed these lines as they actually don't show up in the fetcher log. The reason is that the command would be stuck at https://github.com/apache/mesos/blob/c3228f3c3d1a1b2c145d1377185cfe22da6079eb/src/hdfs/hdfs.cpp#L118 src/tests/slave_tests.cpp (line 368) <https://reviews.apache.org/r/50000/#comment212880> No space. src/tests/slave_tests.cpp (line 376) <https://reviews.apache.org/r/50000/#comment212882> No space. src/tests/slave_tests.cpp (lines 385 - 386) <https://reviews.apache.org/r/50000/#comment212883> Fits in one line. - Jiang Yan Xu On Aug. 16, 2016, 10:35 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50000/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 10:35 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5763 > https://issues.apache.org/jira/browse/MESOS-5763 > > > Repository: mesos > > > Description > ------- > > Added test to simulate the scenario of slow/unresponsive HDFS leading > to executor register timeout and verify that slave gets notified of the > failure. > > > Diffs > ----- > > src/tests/slave_tests.cpp 30ca3da6ca2f1e068bb3f8a6abc7efeebd5bfe8c > > Diff: https://reviews.apache.org/r/50000/diff/ > > > Testing > ------- > > Testing done with make check on linux > > > Thanks, > > Megha Sharma > >
