-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51374/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049
Repository: mesos
Description
-------
This commit changes the master so that we always update the registry for
an important change (e.g., slave removal or reregistration), before
updating any of the master's in-memory state. Previously, the registry
was updated first for registration, but second for removal and
reregistration. Updating the registry first is simpler, and also avoids
the possibility of leaking inaccurate information (e.g., via HTTP
endpoints) if the registry operation fails.
Diffs
-----
src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad
src/master/master.cpp 910293ad16a4eab5ac1e0815406f42dda90c4896
src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6
src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473
src/tests/slave_tests.cpp dcf84545354dd2ae0ab5acad3b15eca0467b9982
Diff: https://reviews.apache.org/r/51374/diff/
Testing
-------
make check
Thanks,
Neil Conway
