----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/#review148606 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp (line 5753) <https://reviews.apache.org/r/51374/#comment216059> CHECK_NOTNULL(slave); src/master/master.cpp (line 7193) <https://reviews.apache.org/r/51374/#comment216060> CHECK_NOTNULL(slave); src/master/master.cpp (line 7247) <https://reviews.apache.org/r/51374/#comment216061> s/from/for/ - Vinod Kone On Sept. 12, 2016, 10:05 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51374/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 10:05 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4049 and MESOS-6090 > https://issues.apache.org/jira/browse/MESOS-4049 > https://issues.apache.org/jira/browse/MESOS-6090 > > > Repository: mesos > > > Description > ------- > > This commit changes the master so that we always update the registry > for an important change (e.g., removing an agent or marking an agent > unreachable), before updating the important parts of the master's > in-memory state (e.g., the in-memory list of registered agents). > Previously, the registry was updated first for registration and > reregistration, but second for removal and marking unreachable. > Updating the registry first is simpler, and also avoids possibly > leaking inaccurate information (e.g., via HTTP endpoints) if the > registry operation fails. > > > Diffs > ----- > > src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 > src/master/master.cpp 1dcce6cd66804990af238176c61aca03bb5c9471 > src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 > src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 > src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 > > Diff: https://reviews.apache.org/r/51374/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
