----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review146777 -----------------------------------------------------------
src/health-check/health_checker.cpp (line 452) <https://reviews.apache.org/r/49360/#comment213438> Will it work on all supported systems? src/health-check/health_checker.cpp (line 518) <https://reviews.apache.org/r/49360/#comment213439> `bash` appears in 3 places and may be extracted to constant. - Tomasz Janiszewski On Aug. 25, 2016, 12:34 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49360/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 12:34 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón > Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-3567 > https://issues.apache.org/jira/browse/MESOS-3567 > > > Repository: mesos > > > Description > ------- > > Supported TCP in health check. > > > Diffs > ----- > > src/health-check/health_checker.hpp > b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 > src/health-check/health_checker.cpp > 45a5fe00a95a6e88b1990c1396e03082feb202bc > > Diff: https://reviews.apache.org/r/49360/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
