----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review146946 -----------------------------------------------------------
Fix it, then Ship it! src/health-check/health_checker.cpp (line 449) <https://reviews.apache.org/r/49360/#comment213847> s/Need to replace/Replace src/health-check/health_checker.cpp (line 465) <https://reviews.apache.org/r/49360/#comment213848> s/exec/create src/health-check/health_checker.cpp (lines 483 - 484) <https://reviews.apache.org/r/49360/#comment213849> "Killing the TCP health check process " fits one line. src/health-check/health_checker.cpp (line 489) <https://reviews.apache.org/r/49360/#comment213851> add "; aborting" src/health-check/health_checker.cpp (lines 495 - 497) <https://reviews.apache.org/r/49360/#comment213852> For readability, let's reformat like in the declaration: const std::tuple< process::Future<Option<int>>, process::Future<std::string>, process::Future<std::string>>& t); src/health-check/health_checker.cpp (line 501) <https://reviews.apache.org/r/49360/#comment213853> As in the previous review, let's settle on either "process" or "subprocess". - Alexander Rukletsov On Aug. 25, 2016, 1:25 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49360/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 1:25 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón > Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-3567 > https://issues.apache.org/jira/browse/MESOS-3567 > > > Repository: mesos > > > Description > ------- > > Supported TCP in health check. > > > Diffs > ----- > > src/health-check/health_checker.hpp > b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 > src/health-check/health_checker.cpp > 45a5fe00a95a6e88b1990c1396e03082feb202bc > > Diff: https://reviews.apache.org/r/49360/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
