----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/#review146776 -----------------------------------------------------------
src/health-check/health_checker.hpp (line 52) <https://reviews.apache.org/r/51379/#comment213435> s/tashID/taskID src/launcher/executor.cpp (lines 420 - 421) <https://reviews.apache.org/r/51379/#comment213440> Add ``` NOTE: The command executor shares the network namespace with its task, hence no need to enter the task's "net" namespace. ``` src/launcher/executor.cpp (line 422) <https://reviews.apache.org/r/51379/#comment213441> we should not do it for non-command health checks, because we need access to `curl` binary. `if (task->health_check.type() == HealthCheck::COMMAND && rootfs.isSome())` - Alexander Rukletsov On Aug. 25, 2016, 12:35 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51379/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 12:35 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón > Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Entered the appropriate namespaces of the task during health check. > > > Diffs > ----- > > src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac > src/health-check/health_checker.hpp > b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 > src/health-check/health_checker.cpp > 45a5fe00a95a6e88b1990c1396e03082feb202bc > src/launcher/executor.cpp 71ede1ea4f4e97fe94bd2bd136f17f231cedbce6 > > Diff: https://reviews.apache.org/r/51379/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
