----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/#review147526 -----------------------------------------------------------
src/health-check/health_checker.cpp (line 89) <https://reviews.apache.org/r/51379/#comment214714> ns::setns is not async signal safe. You cannot call it directly. Please take a look at this review https://reviews.apache.org/r/51277/diff/1#index_header - Jie Yu On Aug. 28, 2016, 1:58 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51379/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2016, 1:58 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón > Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-5961 > https://issues.apache.org/jira/browse/MESOS-5961 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac > src/health-check/health_checker.hpp > b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 > src/health-check/health_checker.cpp > 5bdbd2ab45feecfab494bcacfbcc92c396f4f723 > src/launcher/executor.cpp 71ede1ea4f4e97fe94bd2bd136f17f231cedbce6 > > Diff: https://reviews.apache.org/r/51379/diff/ > > > Testing > ------- > > Manual testing of various scenarios for both command and docker executors; > host, bridged, and overlay networks; container and non-container tasks. > Details see here: > https://gist.github.com/haosdent/577e4a527e2a80e2aa1b1eb783870f8d > > > Thanks, > > haosdent huang > >
