----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51393/#review146839 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/provisioner_paths_tests.cpp (lines 90 - 94) <https://reviews.apache.org/r/51393/#comment213571> I would add some comments about the id: ``` ContainerID child1; // parent1/child1 ContainerID child2; // parent1/child2 ContainerID child3; // parent2/child3 ContainerID parent1; // parent1 ContainerID parent2; // parent2 ``` Adjust below accordingly. src/tests/containerizer/provisioner_paths_tests.cpp (lines 109 - 114) <https://reviews.apache.org/r/51393/#comment213572> ``` ASSERT_SOME(os::mdir(containerDir1)); ``` No need for the temp variable. - Jie Yu On Aug. 24, 2016, 9:32 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51393/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 9:32 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and > Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > Added unit test for provisioner recursive listContainers(). > > > Diffs > ----- > > src/tests/containerizer/provisioner_paths_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51393/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
