----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51393/#review147736 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/tests/containerizer/provisioner_paths_tests.cpp (line 86) <https://reviews.apache.org/r/51393/#comment214953> move this right before #105? src/tests/containerizer/provisioner_paths_tests.cpp (lines 88 - 89) <https://reviews.apache.org/r/51393/#comment214954> How about make it less jagged? ``` // TODO(gilbert): Refactor duplicate code // to the unit test class. ``` - Guangya Liu On 八月 29, 2016, 9:20 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51393/ > ----------------------------------------------------------- > > (Updated 八月 29, 2016, 9:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > Added unit test for provisioner recursive listContainers(). > > > Diffs > ----- > > src/tests/containerizer/provisioner_paths_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51393/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
