----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/#review146887 -----------------------------------------------------------
Fix it, then Ship it! src/master/validation.cpp (line 1003) <https://reviews.apache.org/r/51437/#comment213663> How about ``` return Error("'NetworkInfos' must not be set on the task"); ``` src/tests/master_validation_tests.cpp (line 1776) <https://reviews.apache.org/r/51437/#comment213662> What about define a variable first and use this `resource` in both executor and task (#1784)? - Guangya Liu On 八月 25, 2016, 7:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51437/ > ----------------------------------------------------------- > > (Updated 八月 25, 2016, 7:34 p.m.) > > > Review request for mesos, Anand Mazumdar and Guangya Liu. > > > Repository: mesos > > > Description > ------- > > NetworkInfos can only be set on the task group executor. > > > Diffs > ----- > > src/master/validation.cpp 3d2965e4cfaae075f988fd43386bd00c7d807b2e > src/tests/master_validation_tests.cpp > 56e931c348ee7b4923e16ab8664e2b0d93bce8fc > > Diff: https://reviews.apache.org/r/51437/diff/ > > > Testing > ------- > > make check -j20 GTEST_FILTER="*Validation*" > > > Thanks, > > Vinod Kone > >
