> On Aug. 25, 2016, 11:32 p.m., Guangya Liu wrote: > > src/master/validation.cpp, line 1003 > > <https://reviews.apache.org/r/51437/diff/1/?file=1486023#file1486023line1003> > > > > How about > > > > ``` > > return Error("'NetworkInfos' must not be set on the task"); > > ```
NetworkInfos is not a protobuf/C++ object. So didn't want to quote that. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51437/#review146887 ----------------------------------------------------------- On Aug. 25, 2016, 7:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51437/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 7:34 p.m.) > > > Review request for mesos, Anand Mazumdar and Guangya Liu. > > > Repository: mesos > > > Description > ------- > > NetworkInfos can only be set on the task group executor. > > > Diffs > ----- > > src/master/validation.cpp 3d2965e4cfaae075f988fd43386bd00c7d807b2e > src/tests/master_validation_tests.cpp > 56e931c348ee7b4923e16ab8664e2b0d93bce8fc > > Diff: https://reviews.apache.org/r/51437/diff/ > > > Testing > ------- > > make check -j20 GTEST_FILTER="*Validation*" > > > Thanks, > > Vinod Kone > >
