----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51443/#review147021 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/launcher.cpp (line 224) <https://reviews.apache.org/r/51443/#comment213981> No need to print the containerId. The caller is responsible for that. src/slave/containerizer/mesos/linux_launcher.cpp (line 463) <https://reviews.apache.org/r/51443/#comment213982> Ditto on not printing the containerId. src/slave/containerizer/mesos/linux_launcher.cpp (lines 466 - 468) <https://reviews.apache.org/r/51443/#comment213985> Hum, can you add some comment about this case? I think once BenH did the change I mentioned in his review, this will only be case where this is a legacy container (launched by an old launcher that does not do checkpointing). pid is None means the containerizer may or may not forked the container, but crashes before it was able to checkpoint the pid to agent's meta directory. In this case, the container will terminate itself because reading on the control pipe will fail. Maybe we should return None(), instead of a failure in this case because we know that the contaienr must have terminated. src/slave/containerizer/mesos/linux_launcher.cpp (line 473) <https://reviews.apache.org/r/51443/#comment213989> Do you need this temp variable `_status`, can you do ``` return process::reap(...) .then(...) ``` src/slave/containerizer/mesos/linux_launcher.cpp (lines 484 - 486) <https://reviews.apache.org/r/51443/#comment213990> It's also likely that this is a legacy container (launched by old launcher). Please adjust the comments accordingly. src/slave/containerizer/mesos/linux_launcher.cpp (lines 493 - 494) <https://reviews.apache.org/r/51443/#comment213991> Include the path in the error message src/slave/containerizer/mesos/linux_launcher.cpp (lines 497 - 508) <https://reviews.apache.org/r/51443/#comment213992> What if it is partially written? Should we return None() in that case as well (maybe print a WARNING)? - Jie Yu On Aug. 26, 2016, 8:40 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51443/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 8:40 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6088 > https://issues.apache.org/jira/browse/MESOS-6088 > > > Repository: mesos > > > Description > ------- > > In order to properly reap the new container 'init' process, we need > introduce a new 'Launcher::wait' command that knows how to reap the > 'init' process directly and then retreive its exit status from the > checkpoint (if necessary). > > In a subsequent commit we will update the mesos containerizer to use > this new functionality. > > > Diffs > ----- > > src/slave/containerizer/mesos/launcher.hpp > 0eae09515d550a2c71ae1414d4a22943f1d09db9 > src/slave/containerizer/mesos/launcher.cpp > 413a8afdc56127a58c9599c436d17d6c98e62434 > src/slave/containerizer/mesos/linux_launcher.hpp > 8fbe1e9742df85b0fc6de46ac81a0c064c845a63 > src/slave/containerizer/mesos/linux_launcher.cpp > 7377316776646e3d660086da3c0d5b494ce8ace4 > src/tests/containerizer/launcher.hpp > 94c62b761a17436841bd19f3bf622cc8f1047876 > src/tests/containerizer/launcher.cpp > a92d9890f0931425d69ef8ce0896d081b8722079 > > Diff: https://reviews.apache.org/r/51443/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
