> On Aug. 26, 2016, 9:04 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/linux_launcher.cpp, lines 497-508 > > <https://reviews.apache.org/r/51443/diff/2/?file=1487159#file1487159line497> > > > > What if it is partially written? Should we return None() in that case > > as well (maybe print a WARNING)?
Even if it is partially written, it should always contain something that can be converted to an integer. Because of this, I don't think it makes sense to just log an error if we can't read the data as an integer. The error is more to check for cases where some bogus data got written into the file by accident. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51443/#review147021 ----------------------------------------------------------- On Aug. 26, 2016, 8:40 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51443/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 8:40 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6088 > https://issues.apache.org/jira/browse/MESOS-6088 > > > Repository: mesos > > > Description > ------- > > In order to properly reap the new container 'init' process, we need > introduce a new 'Launcher::wait' command that knows how to reap the > 'init' process directly and then retreive its exit status from the > checkpoint (if necessary). > > In a subsequent commit we will update the mesos containerizer to use > this new functionality. > > > Diffs > ----- > > src/slave/containerizer/mesos/launcher.hpp > 0eae09515d550a2c71ae1414d4a22943f1d09db9 > src/slave/containerizer/mesos/launcher.cpp > 413a8afdc56127a58c9599c436d17d6c98e62434 > src/slave/containerizer/mesos/linux_launcher.hpp > 8fbe1e9742df85b0fc6de46ac81a0c064c845a63 > src/slave/containerizer/mesos/linux_launcher.cpp > 7377316776646e3d660086da3c0d5b494ce8ace4 > src/tests/containerizer/launcher.hpp > 94c62b761a17436841bd19f3bf622cc8f1047876 > src/tests/containerizer/launcher.cpp > a92d9890f0931425d69ef8ce0896d081b8722079 > > Diff: https://reviews.apache.org/r/51443/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
