> On Aug. 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 505-507 > > <https://reviews.apache.org/r/50841/diff/6/?file=1480594#file1480594line505> > > > > I would just call this variable `gpus` > > Also the comment should read: > > ``` > > // The number of GPUs allocated to the container. > > ``` > > Yubo Li wrote: > `gpus` is with type `std::list<Gpu>` so that it actually not the GPU > numbers. Do you think we will use comments `The number of GPUs`?
You're right. We should say "GPUs allocated to the container" though, not just "GPU". - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review146726 ----------------------------------------------------------- On Aug. 26, 2016, 11:02 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50841/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 11:02 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added control logic to allocate/deallocate GPUs to GPU-related task > when the task is started/terminated. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d > src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 > > Diff: https://reviews.apache.org/r/50841/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
