> On 八月 30, 2016, 6:41 p.m., Guangya Liu wrote: > > @Jiang Yan, what about switch the order of this and > > https://reviews.apache.org/r/51529/ so as to make sure the build will not > > be failed after this merged?
Sorry, I mean the unit test will failed if keeping such order. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51528/#review147331 ----------------------------------------------------------- On 八月 30, 2016, 5:07 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51528/ > ----------------------------------------------------------- > > (Updated 八月 30, 2016, 5:07 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Guangya Liu, > and Joris Van Remoortere. > > > Bugs: MESOS-6074 > https://issues.apache.org/jira/browse/MESOS-6074 > > > Repository: mesos > > > Description > ------- > > To test the fix for a check failure in HierarchicalAllocatorProcess > due to uninitialized sorter pointers. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > ddd48694e5c2d3d01fbff20558a46c1256b3dbc3 > > Diff: https://reviews.apache.org/r/51528/diff/ > > > Testing > ------- > > make check. This test causes CHECK failure without /r/51529/. > > ``` > [ RUN ] HierarchicalAllocatorTest.ResourceMetricsUninitialized > I0830 10:01:15.332293 1601536 process.cpp:3340] Handling HTTP event for > process 'metrics' with path: '/metrics/snapshot' > F0830 10:01:15.334383 1064960 owned.hpp:110] Check failed: 'get()' Must be > non NULL > *** Check failure stack trace: *** > @ 0x10ac6d45a google::LogMessage::Fail() > @ 0x10ac6c435 google::LogMessage::SendToLog() > @ 0x10ac6d119 google::LogMessage::Flush() > @ 0x10ac73f88 google::LogMessageFatal::~LogMessageFatal() > @ 0x10ac6d885 google::LogMessageFatal::~LogMessageFatal() > @ 0x108955169 google::CheckNotNull<>() > @ 0x10912ec20 process::Owned<>::operator->() > @ 0x10912d166 > mesos::internal::master::allocator::internal::HierarchicalAllocatorProcess::_resources_total() > @ 0x1091783bf > _ZZN7process8dispatchIdN5mesos8internal6master9allocator8internal28HierarchicalAllocatorProcessERKNSt3__112basic_stringIcNS7_11char_traitsIcEENS7_9allocatorIcEEEESD_EENS_6FutureIT_EERKNS_3PIDIT0_EEMSK_FSH_T1_ET2_ENKUlPNS_11ProcessBaseEE_clEST_ > @ 0x109178250 > _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRZN7process8dispatchIdN5mesos8internal6master9allocator8internal28HierarchicalAllocatorProcessERKNS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEESG_EENS3_6FutureIT_EERKNS3_3PIDIT0_EEMSN_FSK_T1_ET2_EUlPNS3_11ProcessBaseEE_SW_EEEvDpOT_ > @ 0x109178039 > _ZNSt3__110__function6__funcIZN7process8dispatchIdN5mesos8internal6master9allocator8internal28HierarchicalAllocatorProcessERKNS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEESF_EENS2_6FutureIT_EERKNS2_3PIDIT0_EEMSM_FSJ_T1_ET2_EUlPNS2_11ProcessBaseEE_NSD_ISW_EEFvSV_EEclEOSV_ > @ 0x10850d86c std::__1::function<>::operator()() > @ 0x10ab4cf5c process::ProcessBase::visit() > @ 0x10aba731e process::DispatchEvent::visit() > @ 0x104505821 process::ProcessBase::serve() > @ 0x10ab49c84 process::ProcessManager::resume() > @ 0x10ab55730 > process::ProcessManager::init_threads()::$_1::operator()() > @ 0x10ab553f9 > _ZNSt3__114__thread_proxyINS_5tupleIJZN7process14ProcessManager12init_threadsEvE3$_1EEEEEPvS6_ > @ 0x7fff9835299d _pthread_body > @ 0x7fff9835291a _pthread_start > @ 0x7fff98350351 thread_start > [1] 86750 abort MESOS_VERBOSE=1 GLOG_v=1 ./bin/mesos-tests.sh > --gtest_repeat=1 > ``` > > > Thanks, > > Jiang Yan Xu > >
