> On Aug. 30, 2016, 12:24 p.m., Benjamin Bannier wrote: > >
Thanks for the review! > On Aug. 30, 2016, 12:24 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 465 > > <https://reviews.apache.org/r/51529/diff/1/?file=1488683#file1488683line465> > > > > `s/sorters/sorter/` It's technically still `sorters`, see `frameworkSorters` above. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51529/#review147336 ----------------------------------------------------------- On Aug. 30, 2016, 10:02 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51529/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 10:02 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Guangya Liu, > and Joris Van Remoortere. > > > Bugs: MESOS-6074 > https://issues.apache.org/jira/browse/MESOS-6074 > > > Repository: mesos > > > Description > ------- > > Otherwise the sorter pointers can be uninitialized if the metrics > endpoint is polled before the master is initialized. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > bdbc6d3b5b959990538f4e3b7b1a3b031d9aea05 > src/master/allocator/mesos/hierarchical.cpp > 234ef98529964a0b6d3f132426a6c8ccbb1263ee > > Diff: https://reviews.apache.org/r/51529/diff/ > > > Testing > ------- > > make check. > > Test added in /r/51528/ succeeded. > > > Thanks, > > Jiang Yan Xu > >
