> On Sept. 1, 2016, 1:29 p.m., Michael Park wrote: > > support/mesos-tidy/Dockerfile, line 29 > > <https://reviews.apache.org/r/51525/diff/3/?file=1490039#file1490039line29> > > > > Can this go right after `MAINTAINER`?
Sure, done. > On Sept. 1, 2016, 1:29 p.m., Michael Park wrote: > > support/mesos-tidy/Dockerfile, lines 35-37 > > <https://reviews.apache.org/r/51525/diff/3/?file=1490039#file1490039line35> > > > > Can we try to get rid of this `sslVerify` stuff? > > Michael Park wrote: > It looks like we can get rid of this by installing the `ca-certificates` > package! That does fix it, thanks for looking that one up. > On Sept. 1, 2016, 1:29 p.m., Michael Park wrote: > > support/mesos-tidy/entrypoint.sh, line 26 > > <https://reviews.apache.org/r/51525/diff/3/?file=1490041#file1490041line26> > > > > Do we not need to do > > > > ``` > > CONFIGURE_FLAGS=${CONFIGURE_FLAGS:-''} > > ``` > > > > similar to what we do for `CHECKS` below? > > > > If we don't, it seems to me like we wouldn't need the > > > > ``` > > CHECKS=${CHECKS:-''} > > ``` > > > > either. You are right, `CHECKS` can also go here. > On Sept. 1, 2016, 1:29 p.m., Michael Park wrote: > > support/mesos-tidy/entrypoint.sh, line 29 > > <https://reviews.apache.org/r/51525/diff/3/?file=1490041#file1490041line29> > > > > This is my bad. > > > > ``` > > - bear make tests -j $(nproc) || exit 1 > > + bear make -j $(nproc) tests || exit 1 > > ``` Changed as suggested, not sure what difference it makes though. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/#review147553 ----------------------------------------------------------- On Sept. 1, 2016, 5:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51525/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2016, 5:28 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4907 > https://issues.apache.org/jira/browse/MESOS-4907 > > > Repository: mesos > > > Description > ------- > > This commits adds tooling to both build and execute Mesos-specific > clang-tidy checks. We use a docker container for the execution, and > also provide a script to further streamline the tooling. > > > Diffs > ----- > > support/mesos-tidy.sh PRE-CREATION > support/mesos-tidy/Dockerfile PRE-CREATION > support/mesos-tidy/README.md PRE-CREATION > support/mesos-tidy/entrypoint.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/51525/diff/ > > > Testing > ------- > > The image used in `support/mesos-tidy.sh` is available on dockerhub, and > running that script does produce diagnostics. > > > Thanks, > > Benjamin Bannier > >
