> On Sept. 1, 2016, 11:29 a.m., Michael Park wrote: > > support/mesos-tidy/entrypoint.sh, line 29 > > <https://reviews.apache.org/r/51525/diff/3/?file=1490041#file1490041line29> > > > > This is my bad. > > > > ``` > > - bear make tests -j $(nproc) || exit 1 > > + bear make -j $(nproc) tests || exit 1 > > ``` > > Benjamin Bannier wrote: > Changed as suggested, not sure what difference it makes though.
Nothing functionally. I just saw that you use `make -j $(nproc) install` below. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51525/#review147553 ----------------------------------------------------------- On Sept. 1, 2016, 3:28 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51525/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2016, 3:28 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4907 > https://issues.apache.org/jira/browse/MESOS-4907 > > > Repository: mesos > > > Description > ------- > > This commits adds tooling to both build and execute Mesos-specific > clang-tidy checks. We use a docker container for the execution, and > also provide a script to further streamline the tooling. > > > Diffs > ----- > > support/mesos-tidy.sh PRE-CREATION > support/mesos-tidy/Dockerfile PRE-CREATION > support/mesos-tidy/README.md PRE-CREATION > support/mesos-tidy/entrypoint.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/51525/diff/ > > > Testing > ------- > > The image used in `support/mesos-tidy.sh` is available on dockerhub, and > running that script does produce diagnostics. > > > Thanks, > > Benjamin Bannier > >
